Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.bin/make

On Sun, Nov 30, 2008 at 10:37:55PM +0000, David Laight wrote:
> Module Name:  src
> Committed By: dsl
> Date:         Sun Nov 30 22:37:55 UTC 2008
> Modified Files:
>       src/usr.bin/make: for.c
> Log Message:
> Simplify somewhat the code that parses .for lines.
> Use malloc to allocate space for teh strings (instead of a buf structure)
> to make it mossible to not leak the associated memory (leak not fixed!).
> No functional change intended.

Fixing this obvious bug makes the build start for me:

!       accumFor.vars = bmake_realloc(accumFor.vars, nvars * sizeof(char *));
!       accumFor.vars[nvars] = make_str(data, len);

But I don't see how that could have survived any kind of testing, so I'm
not fixing the "fix" before you check that the rest is correct.

Quentin Garnier - -
"See the look on my face from staying too long in one place
[...] every time the morning breaks I know I'm closer to falling"
KT Tunstall, Saving My Face, Drastic Fantastic, 2007.

Attachment: pgpdcBMmbC6hl.pgp
Description: PGP signature

Home | Main Index | Thread Index | Old Index