[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: src/sys/dev/pci
On Fri, Oct 31, 2008 at 07:59:45AM +0100, Bernd Ernesti wrote:
> I'm not too happy with the n8 obfuscation.
It's not obfuscation. These are the same names the relevant files
have in the vendor's software distribution, which supports many different
operating systems. We would have imported that into dist, but:
1) The vendor has ceased software development for this chip so there will
never be a new version (thus dist/ won't help with updates).
2) We had to change most of the files while porting to NetBSD anyway (so
they would all have ended up in both dist and directly in the kernel
It's somewhat like the situation with cxgb though we tried to be cleaner
than that (at least it's a little smaller, I think).
The driver appears to have originally been named "n8" but I think you can
see what problems that would cause. :-)
> Btw, it is usually the case to mention who reviewed a change if you do
> your first commits.
This is my fault: I could not manage to stay up late enough to review
Darran's commit message! I also forgot that this was his very first
commit, or I would have endeavored to provide more extensive advice.
Main Index |
Thread Index |