Re: CVS commit: src/lib/libc/string

[Kurt Schreiner <ks%ub.uni-mainz.de@localhost>]

On Fri, Feb 22, 2008 at 09:13:42PM +0100, Alan Barrett wrote:
> On Fri, 22 Feb 2008, Alan Barrett wrote:
> > Also, I think the code will do the wrong thing in the case that char is
> > signed and the string contains characters with negative values; I think
> > it needs casts to (unsigned char) in a few places.
> 
> I see that later commits to the same files have fixed this issue.  Thanks.
But that doesn't compile on i386 (on amd64 - at least- it's only a "warning"):

    compile  libc/strpbrk.ln
/u/NetBSD/src/lib/libc/string/strcspn.c(48): warning: bitwise operation on 
signed value possibly nonportable [117]
/u/NetBSD/src/lib/libc/string/strcspn.c(52): warning: bitwise operation on 
signed value possibly nonportable [117]
--- strcspn.ln ---
*** [strcspn.ln] Error code 1
/u/NetBSD/src/lib/libc/string/strpbrk.c(48): warning: bitwise operation on 
signed value possibly nonportable [117]
/u/NetBSD/src/lib/libc/string/strpbrk.c(52): warning: bitwise operation on 
signed value possibly nonportable [117]
--- strpbrk.ln ---
*** [strpbrk.ln] Error code 1
    compile  libc/strspn.ln
/u/NetBSD/src/lib/libc/string/strspn.c(49): warning: bitwise operation on 
signed value possibly nonportable [117]
/u/NetBSD/src/lib/libc/string/strspn.c(53): warning: bitwise operation on 
signed value possibly nonportable [117]
--- strspn.ln ---
*** [strspn.ln] Error code 1

Kurt