Re: CVS commit: src

["Mindaugas R." <rmind%NetBSD.org@localhost>]

yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi) wrote:
> > > > - Why? Note, that we pass the size of the structure.
> > > 
> > > are you asking why i think exporting MAXCPUS is a bad idea?
> > > 
> > > > - Do you have a better suggestion?
> > > 
> > > remove the knowledge of MAXCPUS from userland.
> > 
> > We depend on MAXCPUS only in kernel, since we use size in userland. Do you
> > want to hide it from userland, or replace cpuset_t dependence to MAXCPUS
> > in general?
> 
> actually, at least schedctl seems to depend on MAXCPUS.
> besides, _sched_setaffinity and _sched_getaffinity silently truncates a
> bitmap. it's fine to use it in kernel internally, but not a part of the
> userland abi.
> 
> > Modification to use some static size would not be very comfortable..
> 
> i'm not sure what you mean here.
> you hardcoded a static size (MAXCPUS), which is what i'm not happy with.

Sorry for late reply, let's figure out this. My points was:
- Since MAXCPUS can only be increased, ABI would not be broken;
- MAXCPUS is used to calculate CPUSET_SIZE only;
  I have removed it from schedctl(8);
- Why silent truncation is wrong in this case?

Are you suggesting CPUSET_SIZE to not depend on MAXCPUS?

-- 
Best regards,
Mindaugas
www.NetBSD.org