Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src



> > > - Why? Note, that we pass the size of the structure.
> > 
> > are you asking why i think exporting MAXCPUS is a bad idea?
> > 
> > > - Do you have a better suggestion?
> > 
> > remove the knowledge of MAXCPUS from userland.
> 
> We depend on MAXCPUS only in kernel, since we use size in userland. Do you
> want to hide it from userland, or replace cpuset_t dependence to MAXCPUS in
> general?

actually, at least schedctl seems to depend on MAXCPUS.
besides, _sched_setaffinity and _sched_getaffinity silently truncates a bitmap.
it's fine to use it in kernel internally, but not a part of the userland abi.

> Modification to use some static size would not be very comfortable..

i'm not sure what you mean here.
you hardcoded a static size (MAXCPUS), which is what i'm not happy with.

YAMAMOTO Takashi



Home | Main Index | Thread Index | Old Index