Re: CVS commit: syssrc

[Simon Burge <simonb%netbsd.org@localhost>]

Andy Doran wrote:

> On Sun, 9 Jan 2000, Simon Burge wrote:
> 
> > Log Message:
> > Remove defines for VM_PHYSSEG_STRAT and VM_PHYSSEG_NOADD - these are
> > already in mips/include/vmparam.h.  Now things work again (yo Andy!).
> 
> This clearly illustrates the reprocussions of attempting to have one's
> username pasted all over the source tree. I suggest a truce.
> 
> Seriously though, I didn't add those - just screwed around with some
> comments and no-multiple-inclusion goo.

The problem here was that VM_PHYSSEG_NOADD used to be defined as

        #define VM_PHYSSEG_NOADD        /* can't add RAM after vm_mem_init */

and got changed to

        #define VM_PHYSSEG_NOADD        1

and mips/include/vmparam.h already had an identical declaration to the
former.  When gcc see two *identical* declarations for a #define, it
doesn't complain.  But when the two differ, then it isn't very happy...

A truce is fine (nothing personal intended!), but nothing beats just one
more compile before a commit :-)

Simon.