Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: PR bin/60016 : CVS commit: src/usr.bin/make/unit-tests



Robert Elz <kre%munnari.OZ.AU@localhost> wrote:
> That's not the point of this message - the previous fix for 60016
> worked, this optimisation however is a disaster (if ATF tests failing
> can ever be called that).

Hmmm.
I cannot not get atf-run to work in my env, but the underlying make
command was able to test the previous issues.

> I suspect the reason is that TEST_MAKE is simply undefined in the ATF
> test runs now (or becomes that way), leading to:

unit-tests/Makefile initializes it with:

TEST_MAKE ?= ${.MAKE}

and .MAKE is intialized by make itself.
So it should be at least "make" to begin with.

Which implies the :${M_whence} isn't working as expected.
I don't see how that could be - those macros are used
with bmake on dozens of different OS's.

Still, I've replaced it with the same simple logic as the previous
fix, it works as expected here...
So at least others can follow what it is doing ;-)

HTH
--sjg


Home | Main Index | Thread Index | Old Index