Re: PR bin/60016 : CVS commit: src/usr.bin/make/unit-tests

[Robert Elz <kre%munnari.OZ.AU@localhost>]

    Date:        Tue, 10 Mar 2026 05:02:00 +0000
    From:        "Simon J. Gerraty" <sjg%netbsd.org@localhost>
    Message-ID:  <20260310050200.5C9FEFA2B%cvs.NetBSD.org@localhost>

  | Module Name:	src
  | Committed By:	sjg
  | Date:		Tue Mar 10 05:02:00 UTC 2026
  |
  | Modified Files:
  | 	src/usr.bin/make/unit-tests: Makefile opt-jobs-internal.mk
  | 	    varname-make_stack_trace.mk
  |
  | Log Message:
  | Ensure TEST_MAKE is an absolute path
  |
  | Rather than have multiple tests work out where 'make' is,
  | do it once.
  |
  | PR: 60016

I discovered that if you stick a ':' there, the code that
is supposed to append the commit message to the PR in gnats
fails, and nothing goes there.

That's not the point of this message - the previous fix for 60016
worked, this optimisation however is a disaster (if ATF tests failing
can ever be called that).

I suspect the reason is that TEST_MAKE is simply undefined in the ATF
test runs now (or becomes that way), leading to:

.SUFFIXES: .mk .rawout .out
.mk.rawout:	.META
	@${_MKMSG_TEST:Uecho '#      test '} ${.PREFIX}
	@set -eu; \
	${LIMIT_RESOURCES}; \
	cd ${.OBJDIR}; \
	env -i PATH="$$PATH" ${MAKE_TEST_ENV} ${ENV.${.PREFIX:T}} \
	  ${TEST_MAKE} \
	    -r -C ${.CURDIR} -f ${.IMPSRC} \
	    ${FLAGS.${.PREFIX:T}:U-k} \
	    > ${.TARGET}.tmp 2>&1 \
	&& status=$$? || status=$$?; \
	echo $$status > ${.TARGET:R}.status
	@mv ${.TARGET}.tmp ${.TARGET}

from src/usr.bin/make/unit-tests/Makefile running

	env -i PATH=xxx ... -r -C /path/... ...

resulting in "env: unknown option -r" and everything failing.

Why TEST_MAKE is now turning into nothing I will leave for someone
else to work out, the changes to the Makefile in this commit are the
only possible explanation (nothing else altered from the previous
build which worked, to the following one which failed -- the simplifications
to the actual tests can't be it) but to me the change that was made
is uncomprehensible, so ...

kre