Re: CVS commit: xsrc/external/mit/xterm/dist

[Simon Burge <simonb%NetBSD.org@localhost>]

Hi Roland,

"Roland Illig" wrote:

> Module Name:	xsrc
> Committed By:	rillig
> Date:		Sat May 15 19:30:15 UTC 2021
>
> Modified Files:
>
> 	xsrc/external/mit/xterm/dist: misc.c
>
> Log Message:
>
> xterm: fix Clang build on i386
>
> xsrc/external/mit/xterm/dist/misc.c:3250:47: error: format specifies
> type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned
> int') [-Werror,-Wformat]

-           printf("color  (ignored, length %lu)\n", have);
+           printf("color  (ignored, length %lu)\n", (unsigned long)have);

Would using "%zu" and reverting the cast be a better fix here?

Cheers,
Simon.