Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: CVS commit: xsrc/external/mit/xterm



thanks for looking into this.

"Christos Zoulas" writes:
> Module Name:	xsrc
> Committed By:	christos
> Date:		Mon May 10 12:29:12 UTC 2021
>
> Modified Files:
> 	xsrc/external/mit/xterm/dist: misc.c
> 	xsrc/external/mit/xterm/include: xtermcfg.h
>
> Log Message:
> revert previous, do it differently and explain why.

please explain changes in the commit message, *especially* for
generated files.

for posterity on this list, message is:

--
/*
 * clang treats _Noreturn and __attribute__((__noreturn__)) differently,
 * so we end up labeling xt_error() with _Noreturn and using it in
 * XtSetErrorHandler which is marked with the attribute noreturn, and clang
 * complains. IMHO this is a bug in clang. We tell everyone that we don't
 * have the header, so we use the attribute consistently and everyone is happy.
 */
--

thanks.


.mrg.


Home | Main Index | Thread Index | Old Index