Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/common/lib/libc/arch/x86_64/string



On 15.01.2020 11:56, Andrew Doran wrote:
> Module Name:	src
> Committed By:	ad
> Date:		Wed Jan 15 10:56:49 UTC 2020
> 
> Modified Files:
> 	src/common/lib/libc/arch/x86_64/string: bcmp.S memcmp.S
> 
> Log Message:
> Rewrite bcmp() & memcmp() to not use REP CMPS.  Seems about 5-10x faster for
> small strings on modern hardware.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.3 -r1.4 src/common/lib/libc/arch/x86_64/string/bcmp.S \
>     src/common/lib/libc/arch/x86_64/string/memcmp.S
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
> 

This exact change broke git:

$ git clone git%github.com@localhost:anphsw/memtest86.git
Cloning into 'memtest86'...
remote: Enumerating objects: 3, done.
remote: Counting objects: 100% (3/3), done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 477 (delta 0), reused 1 (delta 0), pack-reused 474
Receiving objects: 100% (477/477), 312.55 KiB | 984.00 KiB/s, done.
Resolving deltas: 100% (290/290), done.
error: wrong index v2 file size in
/public/memtest86/.git/objects/pack/pack-3baed7d30e4536c1173b6c083d81de217e9c829a.idx
error: wrong index v2 file size in
/public/memtest86/.git/objects/pack/pack-3baed7d30e4536c1173b6c083d81de217e9c829a.idx
error: wrong index v2 file size in
/public/memtest86/.git/objects/pack/pack-3baed7d30e4536c1173b6c083d81de217e9c829a.idx
error: wrong index v2 file size in
/public/memtest86/.git/objects/pack/pack-3baed7d30e4536c1173b6c083d81de217e9c829a.idx
error: wrong index v2 file size in
/public/memtest86/.git/objects/pack/pack-3baed7d30e4536c1173b6c083d81de217e9c829a.idx
error: wrong index v2 file size in
/public/memtest86/.git/objects/pack/pack-3baed7d30e4536c1173b6c083d81de217e9c829a.idx
error: wrong index v2 file size in
/public/memtest86/.git/objects/pack/pack-3baed7d30e4536c1173b6c083d81de217e9c829a.idx
error: wrong index v2 file size in
/public/memtest86/.git/objects/pack/pack-3baed7d30e4536c1173b6c083d81de217e9c829a.idx
fatal: bad object 9da11d5d7eaa9f1a6a26c04c22b5422c886699a0
fatal: remote did not send all necessary objects

Userland is now broken.

Please fix.

Attachment: signature.asc
Description: OpenPGP digital signature



Home | Main Index | Thread Index | Old Index