Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys



On 12.01.2020 23:03, Andrew Doran wrote:
> Module Name:	src
> Committed By:	ad
> Date:		Sun Jan 12 22:03:23 UTC 2020
> 
> Modified Files:
> 	src/sys/kern: kern_exec.c kern_runq.c
> 	src/sys/sys: lwp.h sched.h
> 
> Log Message:
> A final set of scheduler tweaks:
> 


Great work!

While there, could we garbage collect unused defines from sys/param.h?

I'm thinking in particular about:

/*
 * Historic priority levels.  These are meaningless and remain only
 * for source compatibility.  Do not use in new code.
 */
#define PSWP    0
#define PVM     4
#define PINOD   8
#define PRIBIO  16
#define PVFS    20
#define PZERO   22
#define PSOCK   24
#define PWAIT   32
#define PLOCK   36
#define PPAUSE  40
#define PUSER   50
#define MAXPRI  127

These symbols from time to time conflict with external loadable kernel
modules. My immediate offender is VirtualBox and PVM symbol name conflict.

Attachment: signature.asc
Description: OpenPGP digital signature



Home | Main Index | Thread Index | Old Index