Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/kern

On Thu, Nov 07, 2019 at 06:46:48PM +0100, Kamil Rytarowski wrote:
> member access within misaligned address 0xffff942d3de8c03c for type
> 'const struct disklabel' which requires 8 byte alignment

OK, why is it 8 byte aligned? Checking....

> revision 1.108
> date: 2011-01-18 20:52:24 +0100;  author: matt;  state: Exp;  lines: +2 -1;
> Make struct disklabel 8 byte aligned.  This increases its size by 4 bytes
> on IPL32 platforms so add code in sys_ioctl (and netbsd32_ioctl) to deal
> with the older/smaller diskabel size.  This change makes disklabel the
> same for both IPL32 and LP64 platforms.

Argh! Somehow I dimly remember having been here already ...
I think I proposed to change the loop to 8 byte increments back then, but
noone knows what odd systems it will the stop working on (none at all is my
personal bet).

So I guess your patch is the best way forward.


Home | Main Index | Thread Index | Old Index