Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/kern

On 07.11.2019 16:45, Kamil Rytarowski wrote:
> On 07.11.2019 16:26, Martin Husemann wrote:
>> On Thu, Nov 07, 2019 at 02:53:08PM +0100, Kamil Rytarowski wrote:
>>> On 07.11.2019 14:25, Valery Ushakov wrote:
>>>> If the sanitizer does complain about other uses, there is little point
>>>> in fixing one instance and not the others.
>>> We already agreed with Christos that this is appeasing of GCC. If you
>>> want to scan the whole kernel (or whole C) file for more occurrences of
>>> violations - please go for it.
>> No. The commit needs to be reverted, and then
>>  a) either the root cause for the unaligned address be fixed or
>>  b) some other means be found to make the sanitizer shut up
>> As uwe said: papering over a tiny detail that *never* hits in the real
>> world but potentialy hiding a real issue is not the way to go.
> I don't have a readily available reproducer locally but it was breaking
> syzbot from booting after the switch to gcc8. I will fix it differently
> aligning the whole struct (so the same approach as we use in userland)
> and backout this change.

Please review:

This patch works for me.

Patch inspired by:

Avoid misaligned access in disklabel(8) in find_label()

After landing it I will revert "Avoid unaligned pointer arithmetic in

Attachment: signature.asc
Description: OpenPGP digital signature

Home | Main Index | Thread Index | Old Index