Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/acpi

On Mon, Aug 05, 2019 at 10:12:04AM +0000, SAITOH Masanobu wrote:
> Module Name:	src
> Committed By:	msaitoh
> Date:		Mon Aug  5 10:12:04 UTC 2019
> Modified Files:
> 	src/sys/dev/acpi: acpi_ec.c
> Log Message:
> - Fix a bug that acpiec_space_handler() doesn't access more than 64bit
>   correctly. Found by kUBSan on Thinkpad X220. acpiec0 accessed 128bits from
>   address 0xa0. The error message was:
> 	UBSan: Undefined Behavior in ../../../../dev/acpi/acpi_ec.c:672:32, shift exponent 64 is too large for 64-bit type 'long unsigned int'

Ignore all the gracious changes that make the diff harder to read than
necessary, doesn't this break the case of width == 0?


Home | Main Index | Thread Index | Old Index