Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/acpi



On 2019/08/05 19:12, SAITOH Masanobu wrote:
> Module Name:	src
> Committed By:	msaitoh
> Date:		Mon Aug  5 10:12:04 UTC 2019
> 
> Modified Files:
> 	src/sys/dev/acpi: acpi_ec.c
> 
> Log Message:
> - Fix a bug that acpiec_space_handler() doesn't access more than 64bit
>   correctly. Found by kUBSan on Thinkpad X220. acpiec0 accessed 128bits from

s/acpi0/acpiecdt0/

>   address 0xa0. The error message was:
> 
> 	UBSan: Undefined Behavior in ../../../../dev/acpi/acpi_ec.c:672:32, shift exponent 64 is too large for 64-bit type 'long unsigned int'
> 
> - KNF.
> The error message was:
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.75 -r1.76 src/sys/dev/acpi/acpi_ec.c
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
> 


-- 
-----------------------------------------------
                SAITOH Masanobu (msaitoh%execsw.org@localhost
                                 msaitoh%netbsd.org@localhost)


Home | Main Index | Thread Index | Old Index