Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src



> On 1. Jun 2019, at 13:44, Robert Elz <kre%munnari.OZ.AU@localhost> wrote:
> 
>    Date:        Sat, 1 Jun 2019 10:34:41 +0200
>    From:        "J. Hannken-Illjes" <hannken%eis.cs.tu-bs.de@localhost>
>    Message-ID:  <FE410818-862B-45EE-9523-4BA295BC6177%eis.cs.tu-bs.de@localhost>
> 
>  | This looks wrong -- you should have added an weak alias to
>  | sys/rump/librump/rumpkern/emul.c to handle the case where
>  | librumpvfs is not present.
> 
> I have no idea how that could have fixed things - if librump
> wants to call a function that exists in librumpvfs then librumpvfs
> needs to be there doesn't it?    Perhaps none of the current
> functions need that, because they're probably not going to
> exercise the new code, but they could.
> 
> Still, if you have a better way that will actually fix things, by
> all means, do it.

Problem is sys/kern/kern_proc.c gets loaded into librump while
getcwd_common is in librumpvfs.  For the librump-only case
we have to supply stubs to librumpvfs functions.

The attached diff should do the job -- unfortunately my
build and test machine is not working aqt the moment.

--
J. Hannken-Illjes - hannken%eis.cs.tu-bs.de@localhost - TU Braunschweig

Attachment: emul.c.diff
Description: Binary data

Attachment: signature.asc
Description: Message signed with OpenPGP



Home | Main Index | Thread Index | Old Index