Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src



> On 1. Jun 2019, at 08:59, Robert Elz <kre%netbsd.org@localhost> wrote:
> 
> Module Name:	src
> Committed By:	kre
> Date:		Sat Jun  1 06:59:18 UTC 2019
> 
> Modified Files:
> 	src/tests/dev/usb/t_hid: Makefile
> 	src/tests/lib/semaphore/pthread: Makefile
> 	src/tests/net/bpfjit: Makefile
> 	src/tests/net/icmp: Makefile
> 	src/tests/net/if: Makefile
> 	src/tests/net/if_loop: Makefile
> 	src/tests/rump/rumpkern/h_server: Makefile
> 	src/usr.bin/rump_server: Makefile
> 
> Log Message:
> Deal with fallout from the addition of
> 	KERN_PROC_CWD in sysctl(3)
> That is kern.proc.$$.KERN_PROC_CWD (I think - not that it matters here)
> 
> The effect is that -lrump now requires -lrumpvfs
> 
> This set of changes fixes (I believe) regular dynamic builds,
> more might be required for static builds (will be verified soon).
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.2 -r1.3 src/tests/dev/usb/t_hid/Makefile
> cvs rdiff -u -r1.4 -r1.5 src/tests/lib/semaphore/pthread/Makefile
> cvs rdiff -u -r1.7 -r1.8 src/tests/net/bpfjit/Makefile
> cvs rdiff -u -r1.10 -r1.11 src/tests/net/icmp/Makefile
> cvs rdiff -u -r1.8 -r1.9 src/tests/net/if/Makefile
> cvs rdiff -u -r1.5 -r1.6 src/tests/net/if_loop/Makefile
> cvs rdiff -u -r1.5 -r1.6 src/tests/rump/rumpkern/h_server/Makefile
> cvs rdiff -u -r1.12 -r1.13 src/usr.bin/rump_server/Makefile
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.

This looks wrong -- you should have added an weak alias to
sys/rump/librump/rumpkern/emul.c to handle the case where
librumpvfs is not present.

Please revert and fix correctly.

--
J. Hannken-Illjes - hannken%eis.cs.tu-bs.de@localhost - TU Braunschweig




Attachment: signature.asc
Description: Message signed with OpenPGP



Home | Main Index | Thread Index | Old Index