Re: CVS commit: src/sys/arch

[Maxime Villard <max%m00nbsd.net@localhost>]

Le 28/01/2019 à 03:36, David Holland a écrit :
> On Sun, Jan 27, 2019 at 07:10:24PM +0100, Maxime Villard wrote:
>   > > Restore satlink's majors entries commented out and marked obsolete.
>   > > Otherwise they might accidentally get reused later and cause a
>   > > security problem.
>   >
>   > This is completely useless, please revert. You are re-adding references
>   > to satlink without a good reason.
>
> There's a good reason right there in the commit message, y'know. No,
> I'm not going to revert it.

The policy is to add majors at the end of the list, not in the middle.
Keeping 'obsolete' comments doesn't change anything to this policy, and
therefore doesn't solve any problem.

Given that you are yourself unsure about what drivers may have been
obsoleted in the past (judging by your commit message), it's still unclear
if some free slots can be reused safely.

In other words, this change is still pretty much useless in practice.

But:

>   > We've never marked entries as obsolete in majors (just check amd64's
>   > cvs log). If you really think this matters, then please add all the
>   > obsoletes that are needed after all these years of changes.
>
> Yes, that's done now. It became clear that it was necessary, but it
> took a while.

Thanks for that. I'm fine with this new policy (of keeping comments of
what was unreferenced), and, at least spiritually, it is probably better
than not keeping comments at all.

> (Your recent removals were more than half the work.)

Yes, they were in the continuity of what we had been doing for 15+ years,
and were consistent with our policy. Your changes weren't initially...

But it's mostly fixed now, thanks for that.