Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/external/cddl/osnet/dev/dtrace/i386

On Jun 5,  8:10am, kre%munnari.OZ.AU@localhost (Robert Elz) wrote:
-- Subject: Re: CVS commit: src/external/cddl/osnet/dev/dtrace/i386

| Yes, that's what I would have thought .... but I just copied the position in 
| the amd64 version of the file.

It is unfortunate that the files have diverged unnecessarly. Perhaps we
should fix that and push the changes upstream.

| I see you changed this - it would be a good idea to make the same
| change in the amd64 version, and avoid yet another meaningless
| difference between the two.

Yes, I don't want to keep adding <sys/proc.h> to each architecture that
includes that dtrace header file :-)

| For this (and an earlier, that someone else fixed) of the recent build
| failures, I have been looking at the i386 vs amd64 versions of the
| "same" files (not dtrace/cddl, I don't much care about that, but regular
| src/sys/arch/{amd64,i386}) - obviously there are differences because
| they are not the same architecture, but there are lots of other differences
| that seem completely pointless (eg: in one file, in both versions, there is
| a comment, where the wording is identical, but one of them ends with a
| period (full stop) and the other does not ... a completely pointless
| difference that makes looking to see what is actually different between
| the two much harder.
| There are a whole lot more.



Home | Main Index | Thread Index | Old Index