Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/external/cddl/osnet/dev/dtrace/i386

    Date:        Mon, 4 Jun 2018 21:31:34 +0000 (UTC)
    From: (Christos Zoulas)
    Message-ID:  <pf4b3m$8df$>

  | That should come after <sys/param.h>... In general "infrastructure"
  | headers before "feature" headers... I will fix it (it happens to work,
  | but)...

Yes, that's what I would have thought .... but I just copied the position in 
the amd64 version of the file.

I see you changed this - it would be a good idea to make the same
change in the amd64 version, and avoid yet another meaningless
difference between the two.

For this (and an earlier, that someone else fixed) of the recent build
failures, I have been looking at the i386 vs amd64 versions of the
"same" files (not dtrace/cddl, I don't much care about that, but regular
src/sys/arch/{amd64,i386}) - obviously there are differences because
they are not the same architecture, but there are lots of other differences
that seem completely pointless (eg: in one file, in both versions, there is
a comment, where the wording is identical, but one of them ends with a
period (full stop) and the other does not ... a completely pointless
difference that makes looking to see what is actually different between
the two much harder.

There are a whole lot more.


Home | Main Index | Thread Index | Old Index