Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/crypto/external/bsd/netpgp/dist/src


On 20/02/2017 03:40, Alistair Crooks wrote:
Thanks, but I'd really like it if netpgp would work the same on all
pkgsrc platforms:

The linux man page for getpass(3) (

The function *getpass*() returns a pointer to a static buffer containing
(the first *PASS_MAX* bytes of) the password without the trailing
newline, terminated by a null byte ('\0'). This buffer may be
overwritten by a following call. On error, the terminal state is
restored, /errno/ is set appropriately, and NULL is returned.

Good point; I haven't applied this in pkgsrc yet, and I will revert it from NetBSD's src tree.

-- khorben

On 19 February 2017 at 17:38, Pierre Pronchery <
<>> wrote:

    Module Name:    src
    Committed By:   khorben
    Date:           Mon Feb 20 01:38:28 UTC 2017

    Modified Files:
            src/crypto/external/bsd/netpgp/dist/src/lib: netpgp.c
            src/crypto/external/bsd/netpgp/dist/src/librsa: rsastubs.c

    Log Message:
    Remove a useless loop around getpass()

    According to getpass(3), this library function cannot return NULL.
    Verified with a source code inspection.

    To generate a diff of this commit:
    cvs rdiff -u -r1.98 -r1.99 \
    cvs rdiff -u -r1.2 -r1.3 \

    Please note that diffs are not public domain; they are subject to the
    copyright notices on the relevant files.


Home | Main Index | Thread Index | Old Index