Re: CVS commit: src/crypto/external/bsd/netpgp/dist/src

[Alistair Crooks <agc%pkgsrc.org@localhost>]

Thanks, but I'd really like it if netpgp would work the same on all pkgsrc platforms:

The linux man page for getpass(3) (https://linux.die.net/man/3/getpass) says:

The function getpass() returns a pointer to a static buffer containing (the first PASS_MAX bytes of) the password without the trailing newline, terminated by a null byte ('\0'). This buffer may be overwritten by a following call. On error, the terminal state is restored, errno is set appropriately, and NULL is returned.

On 19 February 2017 at 17:38, Pierre Pronchery <khorben%netbsd.org@localhost> wrote:

Module Name:    src
Committed By:   khorben
Date:           Mon Feb 20 01:38:28 UTC 2017

Modified Files:
        src/crypto/external/bsd/netpgp/dist/src/lib: netpgp.c
        src/crypto/external/bsd/netpgp/dist/src/librsa: rsastubs.c

Log Message:
Remove a useless loop around getpass()

According to getpass(3), this library function cannot return NULL.
Verified with a source code inspection.


To generate a diff of this commit:
cvs rdiff -u -r1.98 -r1.99 \
    src/crypto/external/bsd/netpgp/dist/src/lib/netpgp.c
cvs rdiff -u -r1.2 -r1.3 \
    src/crypto/external/bsd/netpgp/dist/src/librsa/rsastubs.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.