Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/tests/kernel



In article <19801.1478175371%andromeda.noi.kre.to@localhost>,
Robert Elz  <kre%munnari.OZ.AU@localhost> wrote:
>
>Which is actually correct?   (That is, which makes more sense, if it is
>not actually specified somewhere.)
>
>Please make the tests test correct behaviour, not just what NetBSD happens
>to do today.   If NetBSD is doing something that is not correct, file a PR
>and use atf_expect_fail() referencing the PR so it can get fixed, someday.
>
>Of course, it is also possible that the linux behaviour is the one that's
>wrong.
>
>  | This code covers (uncovers issues?) WIFCONTINUED() and is the last planned
>  | test in the ptraceme category.
>
>It would be kind of nice to have some (similar) tests that use waitid()
>(or wait6()) instead of waitpid() given that waitid() is the more modern
>(and more flexible) interface.

Well, having both WIFSTOPPED and WIFCONTINUED set does not make a lot of sense.
It would seem that the right behavior is that WIFCONTINUED should be set
and WIFSTOPPED not set after PT_CONTINUE (unless the child stopped again).

Anyway, for FreeBSD WIFSTOPPED is set and WIFCONTINUED is not, so my guess
is that the child is stopped again and we are wrong somewhere forgetting
to clear the continued flag.

christos



Home | Main Index | Thread Index | Old Index