Re: CVS commit: src/tests/kernel

[Robert Elz <kre%munnari.OZ.AU@localhost>]

    Date:        Thu, 3 Nov 2016 11:20:45 +0000
    From:        "Kamil Rytarowski" <kamil%netbsd.org@localhost>
    Message-ID:  <20161103112045.A48AAFBA6%cvs.NetBSD.org@localhost>

  | This test verifies calling raise(2) with the SIGCONT argument in the child.
  | The parent is notified with it and asserts that WIFCONTINUED() and
  | WIFSTOPPED() are both set.
  | 
  | XXX: This behavior is surprising. Linux for the same code-path returns false
  | for WIFCONTINUED() and true for WIFSTOPPED().

Which is actually correct?   (That is, which makes more sense, if it is
not actually specified somewhere.)

Please make the tests test correct behaviour, not just what NetBSD happens
to do today.   If NetBSD is doing something that is not correct, file a PR
and use atf_expect_fail() referencing the PR so it can get fixed, someday.

Of course, it is also possible that the linux behaviour is the one that's
wrong.

  | This code covers (uncovers issues?) WIFCONTINUED() and is the last planned
  | test in the ptraceme category.

It would be kind of nice to have some (similar) tests that use waitid()
(or wait6()) instead of waitpid() given that waitid() is the more modern
(and more flexible) interface.

kre

ps: I notice that the code you included in the commit log references
sys_errlist[] explicitly - please don't do that, use strerror() instead.