Re: CVS commit: src/usr.bin/config

[Roy Marples <roy%marples.name@localhost>]

On 09/09/2016 22:09, Christos Zoulas wrote:
> Module Name:	src
> Committed By:	christos
> Date:		Fri Sep  9 21:09:11 UTC 2016
> 
> Modified Files:
> 	src/usr.bin/config: defs.h files.c sem.c
> 
> Log Message:
> Make attribute deselection work:
> - when deselecting attributes, remove files that depend on them
> - when deselecting attributes, remove devices that depend on them
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.97 -r1.98 src/usr.bin/config/defs.h
> cvs rdiff -u -r1.35 -r1.36 src/usr.bin/config/files.c
> cvs rdiff -u -r1.75 -r1.76 src/usr.bin/config/sem.c

#   compile  config/sem.o
/home/roy/tools/amd64/bin/x86_64--netbsd-clang -O2 -g -fPIE
-fstack-protector -Wstack-protector  --param ssp-buffer-size=1
-std=gnu99     -Wno-sign-compare -Wno-pointer-sign  -Wall
-Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith
-Wno-sign-compare  -Wa,--fatal-warnings -Wreturn-type -Wswitch -Wshadow
-Wcast-
qual -Wwrite-strings -Wextra -Wno-unused-parameter -Wno-sign-compare
-Wold-style-definition -Wconversion -Wsign-compare -Wformat=2
-Wpointer-sign -Wmissing-no
return  -Werror -Wno-format-y2k  -pipe
--sysroot=/home/roy/src/src/obj/destdir.amd64
-I/home/roy/src/src/usr.bin/config -I. -I/home/roy/src/src/usr.bin/cksum
-D_FORTIFY_SOURCE=2 -c    /home/roy/src/src/usr.bin/config/sem.c
/home/roy/src/src/usr.bin/config/sem.c:351:29: error: variable 'a' is
uninitialized when used here [-Werror,-Wuninitialized]
                    addvalue(V_ATTRIBUTE, a, dep));
                                          ^
/home/roy/src/src/usr.bin/config/defs.h:528:68: note: expanded from
macro 'ht_insert2'
#define ht_insert2(ht, nam1, nam2, val) ht_insrep2(ht, nam1, nam2, val, 0)
                                                                   ^~~
/home/roy/src/src/usr.bin/config/sem.c:336:16: note: initialize the
variable 'a' to silence this warning
        struct attr *a, *dep;
                      ^
                       = NULL
1 error generated.
*** [sem.o] Error code 1