Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch

Yes, if each entry in the path array were treated as a separate test case, then we could certainly skip the sysmon/power/wdog entries if the open returns ENODEV.

However, there is one big list of paths, all tested in a single test case. It would not make sense to report the entire test case as skipped just because 1-3 of the many entries was ENODEV.

So, even more arguably, the test itself should/could be rewritten to check each path separately, and then the individual sysmon-minor paths can skip on ENODEV.


On Wed, 6 May 2015, Martin Husemann wrote:

On Wed, May 06, 2015 at 07:43:02AM +0800, Paul Goyette wrote:
Arguably, the atf test include/t_paths could have been updated to check
for the specific error ENODEV and treat that as a PASS.

Minor nit: it should skip, not pass.


| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at    |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at  |

Home | Main Index | Thread Index | Old Index