Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: CVS commit: src/sys/arch

For i386 and amd64:

non-XEN GENERIC is MODULAR, and the sysmon drivers will be autoloaded as necesary. Confirmed by successful running of atf test suite.

For other platforms:

MODULAR kernels are unaffected, as drivers will be autoloaded.

Non-MODULAR kernels will contain sysmon sub-components only when there are active "references". For example, if the kernel contains a watchdog device, sysmon_wdog will be included; if it contains a sensor device, sysmon_envsys will be included; and if the kernel contains a power button driver, sysmon_power will be included.

I updated the x86/XEN configs because there are atf tests running, and those tests fail due to non-support of some sysmon sub-components. The only functionality being lost is the ability to run wdogctl(8) or envstat(8) only to find out that there are no watchdog timers or sensors included in the kernel. (Since the kernel is non-MODULAR, there's no chance of adding devices at run-time.) Opening the various sysmon minor device will return ENODEV, rather than having the GETxxx ioctl return empty results.

Arguably, the atf test include/t_paths could have been updated to check for the specific error ENODEV and treat that as a PASS.

On Wed, 6 May 2015, matthew green wrote:

"Paul Goyette" writes:
Module Name:	src
Committed By:	pgoyette
Date:		Tue May  5 22:14:24 UTC 2015

Modified Files:
	src/sys/arch/amd64/conf: XEN3_DOMU
	src/sys/arch/i386/conf: XEN3_DOMU

Log Message:
For non-modular XEN3_DOMU kernels, include sysmon and all of its
subcomponents.  While the wdog and envsys subcomponents aren't
terribly useful in DOMU environment, this restores functionality
to previous (pre-modularized sysmon) state.

does this mean that non-xen GENERIC is missing this functionality?
that's a general regression.


| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at    |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at  |

Home | Main Index | Thread Index | Old Index