Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev

On Tue, May 05, 2015 at 07:47:09PM -0400, Greg Troxel wrote:
> "Michael van Elst" <> writes:
> > Modified Files:
> > 	src/sys/dev: dksubr.c
> >
> > Log Message:
> > warn about labels only when built with DIAGNOSTIC
> This feels like an abuse of DIAGNOSTIC, which is supposed to be about
> asserts for detecting internal inconsistencies, not changing the
> behavior of how the kernel responds to external inputs.
> I don't have any problem with warnings for dodgy external input being
> generally enabled, or having a separate verbose option.   I can't see
> any reason not to have them, as it's not like new labels appearing is a
> high-rate event that would dos the log.

The warnings are restricted to diagnostic kernels only because they
did fill the log on some systems, i.e. those where we provide images
for SD cards of unspecified size. Every device-open (for a device that
happens to already use the dksubr routines) prints the warning,
not just every newly detected bad label.

Saying that, some device drivers have private code that does the
same, some don't or do it in a different way. This excercise is
more about making things more consistent. When we have a method
to keep the noise down to a sane level, it's no problem to enable
the warnings again in a default kernel.

                                Michael van Elst
                                "A potential Snark may lurk in every tree."

Home | Main Index | Thread Index | Old Index