Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/atari/stand/installboot



On Nov 24,  7:18am, tsutsui%ceres.dti.ne.jp@localhost (Izumi Tsutsui) wrote:
-- Subject: Re: CVS commit: src/sys/arch/atari/stand/installboot

| Then you don't have any patch for existing (and not warned) abcksum().
| Are you also okay to specify -fno-strict-aliasing with the original code
| as I and mrg (and now Taylor) suggest, rather than patching only
| warned assignments?

The patch works. It is not future-proof, but it works. There is
currently no way (that I know of) to flag all the strict-aliasing
violations, so the best we can do is to fix the ones the compiler
and warns about. If the compiler does not warn about them, we should
no be concerned yet (unless we find that the compiler produces
undesirable code -- like it did for CIRCLEQ and we saw how difficult
that was to fix). I still maintain that it is better to fix the
strict aliasing violations rather than papering over it with 
-fno-strict-aliasing, but I don't want to spend any more time
arguing about it.


christos


Home | Main Index | Thread Index | Old Index