Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/net



In article <20141119210214.GA8310@neva>,
Alexander Nasonov  <alnsn%yandex.ru@localhost> wrote:
>Christos Zoulas wrote:
>> Module Name:	src
>> Committed By:	christos
>> Date:		Wed Nov 19 19:34:43 UTC 2014
>> 
>> Modified Files:
>> 	src/sys/net: bpfjit.c
>> 
>> Log Message:
>> Add BPF_MOD/BPF_XOR (untested, needs work)
>
>Changes look good.
>
>>  /*
>> + * XXX: Until we support SLJIT_UMOD properly
>> + */
>> +#undef BPFJIT_USE_UDIV
>
>I don't think SLJIT_UMOD exists. You need to emit SLJIT_SUB after
>SLJIT_UDIV. This should be pretty straigthforward. But I don't mind
>if you make a function call for these quite rare instructions. 

Can you please do it? You are the expert :-)

christos



Home | Main Index | Thread Index | Old Index