Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/fs/puffs

On Wed, 15 Oct 2014, David Laight wrote:
Consider what happens if you write:
	if (error)

When DPRINTF() expands 'if (xxx) yyy' it all goes horribly wrong.

That's why I changed it to

	do { if (xxx) yyy; } while (0)

a week or two ago. (That change was not pulled up to netbsd-7, although other changes made around the same time were pulled up.)

Do we need to support any compilers that don't support __VA_ARGS__ ?
Even microsoft's compiler almost supports it.

I don't know.

--apb (Alan Barrett)

Home | Main Index | Thread Index | Old Index