Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/fs/puffs

    Date:        Mon, 6 Oct 2014 14:26:44 +0000
    From:        "Havard Eidnes" <>
    Message-ID:  <>

  | Make this build again without debugging enabled; DPRINTF() can end up
  | as empty, and in an if conditional, you then need braces if that's the
  | only potential body.

That change makes no sense to me - the original code was

	if (error)

and even if DPRINTF() could produce nothing, the result would be

	if (error)

which is perfectly good C (useless, but acceptable).  Adding { } around
the ';' changes nothing.

But in any case, apb changed it yesterday, so DPRINTF() never produces
nothing (personally I'm not sure that should have been needed, but that's
beside the point).

What was the error that resulted in the addition of the {} ?


Home | Main Index | Thread Index | Old Index