Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/ufs/ufs

On Fri, May 16, 2014 at 12:12:00AM +0200, Joerg Sonnenberger wrote:
 > >  > Modified Files:
 > >  >         src/sys/ufs/ufs: inode.h
 > >  > 
 > >  > Log Message:
 > >  > Make filehandles on UFS based filesystems use proper 64bit inodes.
 > >  > 32bit restriction noticed by Taylor R Campbell.
 > > 
 > > I suspect this isn't going to work:
 > I don't think it is a problem by itself as the file handle is opaque,
 > but it is certainly wasteful to not put ufid_ino first.

I've ascertained that it is in fact a problem: this thing is sent
directly on the wire, and it gets memcmp'd, so having padding bytes in
it is going to cause trouble.

Also, if you reboot and update the kernel to add this change all old
file handles will quit working; this probably doesn't matter though.

David A. Holland

Home | Main Index | Thread Index | Old Index