[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: src/sys/ufs/ufs
On Wed, May 14, 2014 at 01:46:19PM +0000, Martin Husemann wrote:
> Modified Files:
> src/sys/ufs/ufs: inode.h
> Log Message:
> Make filehandles on UFS based filesystems use proper 64bit inodes.
> 32bit restriction noticed by Taylor R Campbell.
I suspect this isn't going to work:
u_int16_t ufid_len; /* Length of structure. */
u_int16_t ufid_pad; /* Force 32-bit alignment. */
ino_t ufid_ino; /* File number (ino). */
int32_t ufid_gen; /* Generation number. */
Probably it should be specifically sized, therefore uint64_t; also it
needs padding for 64-bit alignment.
I'm not entirely clear on how this structure is actually used, which
is why I hadn't yet made this change myself after the issue came up. :-/
David A. Holland
Main Index |
Thread Index |