Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/luna68k/dev

On Thu, Jan 02, 2014 at 11:11:34AM -0500, Christos Zoulas wrote:
 > | ISTM that if the field exists, it should always be initialized (in all
 > | tty drivers); if it doesn't need to be initialized, it shouldn't
 > | exist...
 > | 
 > | The tty code is a mess but someday someone will fix it up.
 > grep -rw t_softc /usr/src/sys reveals:
 > ./dev/ic/com.c: tp->t_softc = sc;
 > ./sys/tty.h:    void    *t_softc;               /* pointer to driver's 
 > softc. */
 > And the change was done a long time ago, and still nothing uses it.
 > date: 2013-02-24 01:20:24 -0500;  author: matt;  state: Exp;  lines: +2 -1;
 > Add a t_softc member to struct tty in which a driver can store a pointer
 > to its softc.  (analogous to if_softc in struct ifnet).
 > What's the plan?

Dunno... Cc: added

(my plan has been to invade with torches and pitchforks, but I've been
putting off even looking at it while namei and vfs stuff remain a mess)

David A. Holland

Home | Main Index | Thread Index | Old Index