[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: src/sys/arch/luna68k/dev
On Jan 2, 4:00pm, dholland-sourcechanges%netbsd.org@localhost (David Holland)
-- Subject: Re: CVS commit: src/sys/arch/luna68k/dev
| On Thu, Jan 02, 2014 at 01:25:56PM +0900, Izumi Tsutsui wrote:
| > > This could lead to problems in the future. I would put it back.
| > How?
| > - it was added by me recently
| > - netbsd-6 doesn't have it
| > - no other serial driver except com(4) has it
| ISTM that if the field exists, it should always be initialized (in all
| tty drivers); if it doesn't need to be initialized, it shouldn't
| The tty code is a mess but someday someone will fix it up.
grep -rw t_softc /usr/src/sys reveals:
./dev/ic/com.c: tp->t_softc = sc;
./sys/tty.h: void *t_softc; /* pointer to driver's softc. */
And the change was done a long time ago, and still nothing uses it.
date: 2013-02-24 01:20:24 -0500; author: matt; state: Exp; lines: +2 -1;
Add a t_softc member to struct tty in which a driver can store a pointer
to its softc. (analogous to if_softc in struct ifnet).
What's the plan?
Main Index |
Thread Index |