Re: CVS commit: src/sys/arch/x86/pci

[SAITOH Masanobu <msaitoh%execsw.org@localhost>]

(2013/11/13 0:40), Christoph Egger wrote:
> On 12.11.13 16:38, SAITOH Masanobu wrote:
>> (2013/11/13 0:12), Christoph Egger wrote:
>>> On 12.11.13 16:08, SAITOH Masanobu wrote:
>>>> Module Name:       src
>>>> Committed By:      msaitoh
>>>> Date:              Tue Nov 12 15:08:01 UTC 2013
>>>>
>>>> Modified Files:
>>>>    src/sys/arch/x86/pci: amdtemp.c
>>>>
>>>> Log Message:
>>>>  Calcurate the processor family correctly. The extended family bits
>>>> should be added only when the base family is 0xf.
>>>>
>>>>
>>>
>>> The old code is correct as the extended family bits are 0 when base
>>> family is < 0xf. Also, the amdtemp driver does not attach on such
>>> old cpus.
>>>
>>> Christoph
>>
>>  My change doesn't break anything, right? It's intentional.
> 
> No, it does not break anything.

 Thanks. The reason why I didn't write "Fix a bug that..." was
that I knew it wasn't broken :)


>> I'm now fixing and rewriting macros for cpu family and model
>> to avoid trivial bugs and to reduce the code duplication.
> 
> Ok.
> 
> Christoph

 I'll add some bugfixes with individual commit to state each bug.

-- 
-----------------------------------------------
                SAITOH Masanobu (msaitoh%execsw.org@localhost
                                 msaitoh%netbsd.org@localhost)