Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/x86/pci



(2013/11/13 0:12), Christoph Egger wrote:
> On 12.11.13 16:08, SAITOH Masanobu wrote:
>> Module Name: src
>> Committed By:        msaitoh
>> Date:                Tue Nov 12 15:08:01 UTC 2013
>>
>> Modified Files:
>>      src/sys/arch/x86/pci: amdtemp.c
>>
>> Log Message:
>>  Calcurate the processor family correctly. The extended family bits
>> should be added only when the base family is 0xf.
>>
>>
> 
> The old code is correct as the extended family bits are 0 when base
> family is < 0xf. Also, the amdtemp driver does not attach on such
> old cpus.
> 
> Christoph

 My change doesn't break anything, right? It's intentional.
I'm now fixing and rewriting macros for cpu family and model
to avoid trivial bugs and to reduce the code duplication.

 The change of rev. 1.17 is to make future changes clear.

-- 
-----------------------------------------------
                SAITOH Masanobu (msaitoh%execsw.org@localhost
                                 msaitoh%netbsd.org@localhost)


Home | Main Index | Thread Index | Old Index