Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/pci

On 23/07/2013, at 09.54, Martin Husemann <> wrote:
> What are you doing here, and why can't you do a full new bus_space_map here?
> I guess resource handling would not matter a lot for the is_console case.
> (I haven't looked at the changes in details)

puc.c currently first maps the full spaces from the PCI BAR's and then creates 
a subregion for each of the com/lpt devices according to the list of known 
devices in pucdata.c, sometimes more than one per BAR.

The pre-autoconf console code creates a bus_space handle (not a subregion of 
anything) for the console com, which conflicts with puc.c later trying to 
allocate the larger handle that the console is a subregion (but not a 
bus_space_subregion) of.

Really, puc.c should just be turned on its head, identifying sub-devices first 
and only then worrying about bus_space mappings, but there's also some 
device-specific code in there that I can't test, so I was reluctant to do that.


Home | Main Index | Thread Index | Old Index