Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/pci

On Tue, Jul 23, 2013 at 09:43:30AM +0200, Soren Jorvang wrote:

> It would probably work, at least on platforms with simple bus_space
> implementations, but taking a subregion that is outside the original
> region seems iffy, so I have just marked it as an x86 hack for now.

No, it is strictly forbidden:

     The subregion described by the new handle starts at byte offset offset
     into the region described by handle, with the size given by size, and
     must be wholly contained within the original region.

What are you doing here, and why can't you do a full new bus_space_map here?
I guess resource handling would not matter a lot for the is_console case.
(I haven't looked at the changes in details)

Anyway, thanks for fixing!


Home | Main Index | Thread Index | Old Index