[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: src/share/mk
On Tue, Dec 11, 2012 at 09:25:38AM +1100, matthew green wrote:
> > Module Name: src
> > Committed By: pooka
> > Date: Mon Dec 10 20:58:55 UTC 2012
> > Modified Files:
> > src/share/mk: bsd.gcc.mk
> > Log Message:
> > Deal with crti and crtn not present in some EXTERNAL_TOOLCHAIN's. Also,
> > handle "missing" crtstuff internally instead of depending on external
> > intervention.
> what is this change for?
> using sed here is wrong, irrespective of the comment reason you've
> given. if TOOL_SED isn't available, we shouldn't even be processing
> this file yet. that seems like the fix you should look for here.
> what is this EXTERNAL_TOOLCHAIN you're using? i'm totally at a loss
> what this change is useful for besides re-adding a host dependancy
> on sed.
It would be better to use make conditionals to fix the strings.
David Laight: david%l8s.co.uk@localhost
Main Index |
Thread Index |