Re: CVS commit: src/sys

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Mon, Jul 02, 2012 at 11:13:51PM +0100, Mindaugas Rasiukevicius wrote:
> "Manuel Bouyer" <bouyer%netbsd.org@localhost> wrote:
> > Module Name:        src
> > Committed By:       bouyer
> > Date:               Mon Jul  2 18:15:48 UTC 2012
> > 
> > ...
> > 
> > Log Message:
> > Add sata Port MultiPlier (PMP) support to the ata bus layer,
> > as described in
> > http://mail-index.netbsd.org/tech-kern/2012/06/23/msg013442.html
> > PMP support in integrated to the atabus layer.
> 
> Nice piece of development!
> 
> Few minor points.  Does atabus_alloc_drives() need to use M_NOWAIT and
> malloc(9), instead of kmem(9)?

At first glance I'd say it should always be called from the atabus thread,
so it should be OK

> Also, any reason why you use tsleep(9)
> instead of kpause(9) (in satapmp_subr.c and elsewhere)?  We are trying
> to get rid of the former.

kpause(9) could be used here. But I prefer to keep sys/dev/ata consistent
and convert all the code to kpause at the same time. It could have been
done here, I just didn't think about it.
Next opportunity will be with NCQ support, which I hope to look at soon.
This also would be the time to make ata(4) MP-safe.

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--