Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys

"Manuel Bouyer" <> wrote:
> Module Name:  src
> Committed By: bouyer
> Date:         Mon Jul  2 18:15:48 UTC 2012
> ...
> Log Message:
> Add sata Port MultiPlier (PMP) support to the ata bus layer,
> as described in
> PMP support in integrated to the atabus layer.

Nice piece of development!

Few minor points.  Does atabus_alloc_drives() need to use M_NOWAIT and
malloc(9), instead of kmem(9)?  Also, any reason why you use tsleep(9)
instead of kpause(9) (in satapmp_subr.c and elsewhere)?  We are trying
to get rid of the former.


Home | Main Index | Thread Index | Old Index