Re: CVS commit: src/etc/rc.d

[Tetsuya Isaki <isaki%pastel-flower.jp@localhost>]

At Wed, 13 Jun 2012 11:35:37 +0900,
Tetsuya Isaki wrote:
> > > >  The rcvar assignment was missing, but shouldn't the normal logic
> > > > skip calling the start command if the rcvar is not YES?
> > > 
> > > Ah, you mean it's enough to add
> > > >> rcvar=${name}
> > > line into rc.d/makemandb instead of checkyesno?
> > 
> > Exactly.
> 
> Is it true?
> I could not disable it with this patch (diff from rev1.1):
> Please show the precise patch which you suggest.

I am sorry, I confirmed that it works.

Then, May I revert my rev 1.2 (to a state of rev 1.1) and
re-commit it (as rev 1.4) to simplify pulling up?
or commit it (as rev 1.3) and pull up 1.2 and 1.3?
---
Tetsuya Isaki <isaki%pastel-flower.jp@localhost / isaki%NetBSD.org@localhost>

> 
> --- makemandb.ORG     2012-03-11 13:27:21.000000000 +0900
> +++ makemandb 2012-06-13 10:35:22.000000000 +0900
> @@ -10,6 +10,7 @@
>  $_rc_subr_loaded . /etc/rc.subr
>  
>  name="makemandb"
> +rcvar=$name
>  required_files="/etc/man.conf /usr/sbin/makemandb"
>  start_cmd="makemandb_start"
>  stop_cmd=":"
> 
> ---
> Tetsuya Isaki <isaki%pastel-flower.jp@localhost / isaki%NetBSD.org@localhost>
>