Re: CVS commit: src/etc/rc.d

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Tue, Jun 12, 2012 at 11:34:49PM +0900, Izumi Tsutsui wrote:
> joerg@ wrote:
> 
> > On Tue, Jun 12, 2012 at 10:59:34PM +0900, Izumi Tsutsui wrote:
> > > joerg@ wrote:
> > > 
> > > > > Modified Files:
> > > > >       src/etc/rc.d: makemandb
> > > > > 
> > > > > Log Message:
> > > > > Allows you to disable it if makemandb=NO in rc.conf.
> > > > > Thanks tsutsui@ and Yasushi Oshima.
> > > > 
> > > > Is the manual checkyesno really needed?
> > > 
> > > It's too slow and annoying on non modern x86 machines as fccache.
> > > Isn't it the reason why you added makemandb=YES in 
> > > src/etc/defaults/rc.conf?
> > 
> > It should just run stat on all entries in /usr/share/man etc and be
> > done. So it shouldn't be that bad even on slow hardware after the first
> > run. The rcvar assignment was missing, but shouldn't the normal logic
> > skip calling the start command if the rcvar is not YES?
> 
> Ah, you mean it's enough to add
> >> rcvar=${name}
> line into rc.d/makemandb instead of checkyesno?

Exactly.

Joerg