Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/lib/libc/stdio



Hi,

It seems that lint(1) is not cross build safe, it doesn't handle MD char default type of sign/unsignd. See src/usr.bin/xlint/lint1/tree.c::cvtcon(). They use host MD CHAR_MAX directry ;)

So, if cross building ppc/arm on other arch cause false alarm , "out of range " warnng.

Regards.
--

2012/03/22 10:39 "Joerg Sonnenberger" <joerg%britannica.bec.de@localhost>:
On Thu, Mar 22, 2012 at 01:31:41AM +0000, Christos Zoulas wrote:
> In article <20120322003141.GB1948%britannica.bec.de@localhost>,
> Joerg Sonnenberger  <joerg%britannica.bec.de@localhost> wrote:
> >On Wed, Mar 21, 2012 at 10:20:47AM -0400, Christos Zoulas wrote:
> >> Module Name:       src
> >> Committed By:      christos
> >> Date:              Wed Mar 21 14:20:47 UTC 2012
> >>
> >> Modified Files:
> >>    src/lib/libc/stdio: vfwprintf.c
> >>
> >> Log Message:
> >> unsigned char portability casts
> >
> >This looks wrong. What's the point of it?
>
> What's is wrong with it?

It should be unnecessary. CHAR_MAX is certainly required to fit into
both char and unsigned char.

Joerg


Home | Main Index | Thread Index | Old Index