Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/tests/ipf



I think that this is failure of the tests. The tests were fixed at one point, right before the import of new version was reverted. It appears that the re-import has not quite caught up to the pre-revert state.


On Tue, 27 Mar 2012, Jukka Ruohonen wrote:

On Tue, Mar 27, 2012 at 03:38:50PM +0200, Alan Barrett wrote:
Mark the failing tests as broken. XXX: If no one is willing to maintain
the ipf tests, these should be removed.

I object to this.  If ipf fails its tests, then the fact should be
made clear in the test reports, not hidden by disabling the tests.

Indeed.

But only the maintainer knows whether these are "real" bugs or bugs in the
tests. I don't know whether ipf tries to maintain binary or configuration
compatibility, which seems to be the root of the failures. Frankly, I am not
sure even on what is being tested (thus why all tests should be clear and/or
heavily commented).

I don't know whether the bugs are in ipf or in the tests, but
either way, removing or disabling the tests seems to me to be
counter-productive.

These are not disabled but marked as "bogus". The reports contain a message
about the supposition that the "test case is probably broken". Apparently
someone else has also reached the same conclusions, given that there was even
a specific function to mark ipf-tests as bogus.

- Jukka.

!DSPAM:4f71c92b1981504268243!




-------------------------------------------------------------------------
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com    |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |                          | pgoyette at netbsd.org  |
-------------------------------------------------------------------------


Home | Main Index | Thread Index | Old Index