Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/lib/libc



In article <20120313212708.GA29977%britannica.bec.de@localhost>,
Joerg Sonnenberger  <joerg%britannica.bec.de@localhost> wrote:
>
>Thanks for ignoring my comments. It's especially useful that you
>haven't really addressed any of the points. Checking casts from size_t
>to uint32_t is useless on a good number of our architectures. Other
>places have proper checks already in place, so this just adds bloat.

I did not ignore your comments. I brought them up to core, since it
became apparent to me that we would not reach agreement in this. I
offered core 4 solutions:

1. commit the changes as they are (cast+diagassert)
2. commit just the casts without diagassert
3. close the lint PR, and say this is not going to be fixed
   leaving things as they are.
4. give up on lint and remove it alltogether.

Core voted for (1). They can change their minds and vote again, and I will
make the necessary changes.

christos



Home | Main Index | Thread Index | Old Index