Re: CVS commit: src/lib/libc

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Tue, Mar 13, 2012 at 05:13:51PM -0400, Christos Zoulas wrote:
> Log Message:
> PR/45989: Martin Husemann: lint invocation does include -w only on i386
> 
> - turn lint -w for all the platforms after fixing the lint warnings.
> - add _DIAGASSERTS() for casts that would assign values to types that
>   would not fit.
> - change types, add casts
> - change into ansii prototypes
> - turn on _DIAGNOSTIC for libc (during current, to be eliminated for release
>   builds)

Thanks for ignoring my comments. It's especially useful that you
haven't really addressed any of the points. Checking casts from size_t
to uint32_t is useless on a good number of our architectures. Other
places have proper checks already in place, so this just adds bloat.

Joerg